From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 4/6] writeback: fix writeback_inodes_wb from writeback_inodes_sb
Date: Wed, 09 Jun 2010 14:29:22 +0200 [thread overview]
Message-ID: <4C0F8922.8070702@kernel.dk> (raw)
In-Reply-To: <20100609122552.GA23216@lst.de>
On 2010-06-09 14:25, Christoph Hellwig wrote:
> On Tue, Jun 08, 2010 at 09:51:39PM +0200, Jens Axboe wrote:
>> On 08/06/10 18.14, Christoph Hellwig wrote:
>>> When we call writeback_inodes_wb from writeback_inodes_sb we always have
>>> s_umount held, which currently makes the whole operation a no-op.
>>>
>>> But if we are called to write out inodes for a specific superblock we always
>>> have s_umount held, so replace the incorrect logic checking for WB_SYNC_ALL
>>> which only worked by coincidence with the proper check for an explicit
>>> superblock argument.
>>
>> This is tons better than the pinning, I like it a lot.
>
> Unfortunately I accidentally removed the requeue_io call when we fail
> to pin the inode. This leads to softlockups after heavy I/O load.
>
> Please fold the patch below into this one, or if not possible add it
> to the end of the series.
Oops, not good. I already merged and pushed them out, so I added it to
the end instead.
--
Jens Axboe
next prev parent reply other threads:[~2010-06-09 12:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 16:14 [PATCH 0/6] writeback fixes - slow unmount and others Christoph Hellwig
2010-06-08 16:14 ` [PATCH 1/6] writeback: fix writeback completion notifications Christoph Hellwig
2010-06-08 19:50 ` Jens Axboe
2010-06-15 17:25 ` Jan Kara
2010-06-15 17:30 ` Christoph Hellwig
2010-06-08 16:14 ` [PATCH 2/6] writeback: queue work on stack in writeback_inodes_sb Christoph Hellwig
2010-06-08 19:51 ` Jens Axboe
2010-06-08 16:14 ` [PATCH 3/6] writeback: enforce s_umount locking " Christoph Hellwig
2010-06-15 17:54 ` Jan Kara
2010-06-15 17:59 ` Christoph Hellwig
2010-06-15 18:04 ` Jan Kara
2010-06-08 16:14 ` [PATCH 4/6] writeback: fix writeback_inodes_wb from writeback_inodes_sb Christoph Hellwig
2010-06-08 19:51 ` Jens Axboe
2010-06-09 12:25 ` Christoph Hellwig
2010-06-09 12:29 ` Jens Axboe [this message]
2010-06-08 16:15 ` [PATCH 5/6] writeback: simplify wakeup_flusher_threads Christoph Hellwig
2010-06-08 19:51 ` Jens Axboe
2010-06-08 16:15 ` [PATCH 6/6] writeback: simplify and split bdi_start_writeback Christoph Hellwig
2010-06-08 19:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0F8922.8070702@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).