From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] block: remove wrappers for request type/flags
Date: Fri, 18 Jun 2010 12:27:06 +0200 [thread overview]
Message-ID: <4C1B49FA.4050002@kernel.dk> (raw)
In-Reply-To: <20100618074645.GA13358@lst.de>
On 2010-06-18 09:46, Christoph Hellwig wrote:
> Index: linux-2.6/drivers/md/dm.c
> ===================================================================
> --- linux-2.6.orig/drivers/md/dm.c 2010-06-16 21:15:41.291004448 +0200
> +++ linux-2.6/drivers/md/dm.c 2010-06-17 13:27:26.162009965 +0200
> @@ -792,12 +792,12 @@ static void dm_end_request(struct reques
> {
> int rw = rq_data_dir(clone);
> int run_queue = 1;
> - bool is_barrier = blk_barrier_rq(clone);
> + bool is_barrier = (clone->cmd_flags & REQ_HARDBARRIER)
> struct dm_rq_target_io *tio = clone->end_io_data;
> struct mapped_device *md = tio->md;
> struct request *rq = tio->orig;
Ahem... I think we can safely conclude that you did NOT script the
conversion. I'm not too worried about the typos that cause compilation
failures, I'm worried about the ones that do not.
--
Jens Axboe
prev parent reply other threads:[~2010-06-18 10:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 7:46 [PATCH 1/2] block: remove wrappers for request type/flags Christoph Hellwig
2010-06-18 9:36 ` Jens Axboe
2010-06-18 16:58 ` Christoph Hellwig
2010-06-18 17:35 ` Jens Axboe
2010-06-19 12:59 ` Christoph Hellwig
2010-06-18 10:04 ` Jens Axboe
2010-06-18 10:09 ` Jens Axboe
2010-06-18 10:27 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1B49FA.4050002@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).