From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 1/2] block: remove wrappers for request type/flags Date: Fri, 18 Jun 2010 12:27:06 +0200 Message-ID: <4C1B49FA.4050002@kernel.dk> References: <20100618074645.GA13358@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:60213 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755871Ab0FRK1U (ORCPT ); Fri, 18 Jun 2010 06:27:20 -0400 In-Reply-To: <20100618074645.GA13358@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 2010-06-18 09:46, Christoph Hellwig wrote: > Index: linux-2.6/drivers/md/dm.c > =================================================================== > --- linux-2.6.orig/drivers/md/dm.c 2010-06-16 21:15:41.291004448 +0200 > +++ linux-2.6/drivers/md/dm.c 2010-06-17 13:27:26.162009965 +0200 > @@ -792,12 +792,12 @@ static void dm_end_request(struct reques > { > int rw = rq_data_dir(clone); > int run_queue = 1; > - bool is_barrier = blk_barrier_rq(clone); > + bool is_barrier = (clone->cmd_flags & REQ_HARDBARRIER) > struct dm_rq_target_io *tio = clone->end_io_data; > struct mapped_device *md = tio->md; > struct request *rq = tio->orig; Ahem... I think we can safely conclude that you did NOT script the conversion. I'm not too worried about the typos that cause compilation failures, I'm worried about the ones that do not. -- Jens Axboe