From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] block: remove wrappers for request type/flags
Date: Fri, 18 Jun 2010 19:35:47 +0200 [thread overview]
Message-ID: <4C1BAE73.3070606@kernel.dk> (raw)
In-Reply-To: <20100618165815.GB6256@lst.de>
On 2010-06-18 18:58, Christoph Hellwig wrote:
> On Fri, Jun 18, 2010 at 11:36:10AM +0200, Jens Axboe wrote:
>> On 2010-06-18 09:46, Christoph Hellwig wrote:
>>> Remove all the trivial wrappers for the cmd_type and cmd_flags fields in
>>> struct requests. This allows much easier grepping for different request
>>> types instead of unwinding through macros.
>>
>> Agree. I kind of liked it in the beginning, but it really just adds
>> an extra layer of grep or cscope stack when you forget what it
>> checks specifically.
>>
>> Was this a scripted conversion?
>
> No. And as you already noticed I sent you the version before fixing
> up the make allmodconfig fallout. Here's the fixed one:
Ditto on this one, are there fixes in this one apart from the
problems I posted?
--
Jens Axboe
next prev parent reply other threads:[~2010-06-18 17:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 7:46 [PATCH 1/2] block: remove wrappers for request type/flags Christoph Hellwig
2010-06-18 9:36 ` Jens Axboe
2010-06-18 16:58 ` Christoph Hellwig
2010-06-18 17:35 ` Jens Axboe [this message]
2010-06-19 12:59 ` Christoph Hellwig
2010-06-18 10:04 ` Jens Axboe
2010-06-18 10:09 ` Jens Axboe
2010-06-18 10:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1BAE73.3070606@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).