From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 1/2] block: remove wrappers for request type/flags Date: Fri, 18 Jun 2010 19:35:47 +0200 Message-ID: <4C1BAE73.3070606@kernel.dk> References: <20100618074645.GA13358@lst.de> <4C1B3E0A.5040608@kernel.dk> <20100618165815.GB6256@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:36358 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760105Ab0FRRft (ORCPT ); Fri, 18 Jun 2010 13:35:49 -0400 In-Reply-To: <20100618165815.GB6256@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 2010-06-18 18:58, Christoph Hellwig wrote: > On Fri, Jun 18, 2010 at 11:36:10AM +0200, Jens Axboe wrote: >> On 2010-06-18 09:46, Christoph Hellwig wrote: >>> Remove all the trivial wrappers for the cmd_type and cmd_flags fields in >>> struct requests. This allows much easier grepping for different request >>> types instead of unwinding through macros. >> >> Agree. I kind of liked it in the beginning, but it really just adds >> an extra layer of grep or cscope stack when you forget what it >> checks specifically. >> >> Was this a scripted conversion? > > No. And as you already noticed I sent you the version before fixing > up the make allmodconfig fallout. Here's the fixed one: Ditto on this one, are there fixes in this one apart from the problems I posted? -- Jens Axboe