From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Justin P. Mattock" Subject: Re: [PATCH 2/6]kernel:audit.c Fix warning: variable 'nlh' set but not used Date: Fri, 18 Jun 2010 21:45:09 -0700 Message-ID: <4C1C4B55.8070209@gmail.com> References: <1276288869-16815-1-git-send-email-justinmattock@gmail.com> <1276288869-16815-3-git-send-email-justinmattock@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-audit@redhat.com, zippel@linux-m68k.org, linux-fsdevel@vger.kernel.org, rusty@rustcorp.com.au To: Geert Uytterhoeven Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org > > This is not dead code. NLMSG_NEW() sets up an nlmsg in ab->skb. > If you remove the code, it's no longer initialized. I played around with this code some more, but am still getting confused with nlmsg_new and NLMSG_NEW. if I remove the nlmsghdr struct I can get a clean build without a warning, but still am a bit confused. here is an updated patch let me know if it still needs work.. or if it's legit I can resend this. From 7515a08ba921d3beed33fa5c6b1fbe59cf52e069 Mon Sep 17 00:00:00 2001 From: Justin P. Mattock Date: Fri, 18 Jun 2010 19:44:30 -0700 Subject: [PATCH 4/4] audit Signed-off-by: Justin P. Mattock --- kernel/audit.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/kernel/audit.c b/kernel/audit.c index c71bd26..1d51258 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -1041,7 +1041,6 @@ static struct audit_buffer * audit_buffer_alloc(struct audit_context *ctx, { unsigned long flags; struct audit_buffer *ab = NULL; - struct nlmsghdr *nlh; spin_lock_irqsave(&audit_freelist_lock, flags); if (!list_empty(&audit_freelist)) { @@ -1065,7 +1064,7 @@ static struct audit_buffer * audit_buffer_alloc(struct audit_context *ctx, if (!ab->skb) goto nlmsg_failure; - nlh = NLMSG_NEW(ab->skb, 0, 0, type, 0, 0); + NLMSG_NEW(ab->skb, 0, 0, type, 0, 0); return ab; -- 1.7.1.rc1.21.gf3bd6 Justin P. Mattock