From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Justin P. Mattock" <justinmattock@gmail.com>
Subject: Re: [PATCH 3/6 v2]cifs Fix warnings variables set but not used
Date: Sun, 20 Jun 2010 15:33:54 -0700
Message-ID: <4C1E9752.8040508@gmail.com>
References: <1276980427-24728-1-git-send-email-justinmattock@gmail.com> <20100620171713.782e9104@tlielax.poochiereds.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Jeff Layton <jlayton@samba.org>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20100620171713.782e9104@tlielax.poochiereds.net>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org


>>   		/* since paths are not looked up by component - the parent
>>   		   directories are presumed to be good here */
>>   		renew_parental_timestamps(direntry);
>> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
>> index 75541af..73e540b 100644
>> --- a/fs/cifs/file.c
>> +++ b/fs/cifs/file.c
>> @@ -1312,7 +1312,7 @@ static int cifs_partialpagewrite(struct page *page, unsigned from, unsigned to)
>>   	int rc = -EFAULT;
>>   	int bytes_written = 0;
>>   	struct cifs_sb_info *cifs_sb;
>> -	struct cifsTconInfo *pTcon;
>> +	struct cifsTconInfo *pTcon __attribute__((unused));
>
> This variable can just be removed (along with the spot where it gets
> set later).
>
>>   	struct inode *inode;
>>   	struct cifsFileInfo *open_file;
>>
>
>

one thing I want to make sure of before sending this out, is with file.c
if I remove *pTcon another warning shows up:

   CC [M]  fs/cifs/file.o
fs/cifs/file.c: In function 'cifs_partialpagewrite':
fs/cifs/file.c:1314:23: warning: variable 'cifs_sb' set but not used

with the original patch I had removed this as well, should I do this or 
is this not a good idea?

Justin P. Mattock