Re: [PATCH 2/2] add f_flags to struct statfs(64)

[Ulrich Drepper <drepper@redhat.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/28/2010 11:43 AM, Andreas Dilger wrote:
> I would advocate at least an 8-bit magic value, if there is a concern
> about this field not always being 0-filled on older kernels, or not
> using any ST_VALID flag at all, if it was always zero-filled in the
> past.

Did anyone go back and check which kernel versions didn't clear the
spare fields (if any)?

Instead of using a magic number which doesn't provide 100% security in
that case and steals a number of bits which might be needed in future I
rather see a new syscall.  The new {,f}statfs would be an alias for the
old one, exactly the same implementation.  With this it is much safer to
check for the new kernel behavior.  In future this isn't necessary since
from point on it is guaranteed that the spare bits are zeroed.

- -- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)

iEYEARECAAYFAkwo/ZgACgkQ2ijCOnn/RHSdVQCgzgHQj5A3/MLSYMbxX2xotoye
aPsAnRzGEK0pz7LYQ9mIYUHa/upoFuoS
=3oan
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html