From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 2/7] block: push down BKL into .locked_ioctl Date: Thu, 08 Jul 2010 10:36:15 +0200 Message-ID: <4C358DFF.9090401@kernel.dk> References: <1278514289-21054-1-git-send-email-arnd@arndb.de> <1278514289-21054-3-git-send-email-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , Sam Ravnborg , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, John Kacur , Frederic Weisbecker , linux-scsi@vger.kernel.org To: Arnd Bergmann Return-path: In-Reply-To: <1278514289-21054-3-git-send-email-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 2010-07-07 16:51, Arnd Bergmann wrote: > As a preparation for the removal of the big kernel > lock in the block layer, this removes the BKL > from the common ioctl handling code, moving it > into every single driver still using it. > > diff --git a/drivers/message/i2o/i2o_block.c b/drivers/message/i2o/i2o_block.c > index ad3ddef..fc593fb 100644 > --- a/drivers/message/i2o/i2o_block.c > +++ b/drivers/message/i2o/i2o_block.c > @@ -941,8 +930,7 @@ static const struct block_device_operations i2o_block_fops = { > .owner = THIS_MODULE, > .open = i2o_block_open, > .release = i2o_block_release, > - .ioctl = i2o_block_ioctl, > - .compat_ioctl = i2o_block_ioctl, > + .locked_ioctl = i2o_block_ioctl, > .getgeo = i2o_block_getgeo, > .media_changed = i2o_block_media_changed > }; Hmm? -- Jens Axboe