linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: dedekind1@gmail.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH, RFC] simplify writeback thread creation
Date: Thu, 08 Jul 2010 14:20:34 +0200	[thread overview]
Message-ID: <4C35C292.9020507@kernel.dk> (raw)
In-Reply-To: <20100707225242.GA28802@lst.de>

On 2010-07-08 00:52, Christoph Hellwig wrote:
> Currently the per-bdi writeback thread is only created when there is
> dirty any dirty data on the BDI, and it lazy exists when it's been
> unused for some time.
> 
> This leads to some very complex code, and the need to keep a forker
> thread around.
> 
> This patch removes all this code and simply creates the thread as part
> of the bdi registration.  The downside is that we use up ressoures
> for possible unused devices, although that overhead is rather low,
> with 8k kernel stack size on x86 and few other, even smaller ressources.
> 
> If the overhead is still considered too much I can look into starting
> the thread explicitly instead of as part of the bdi registration, but
> that will require a bit of code complexity, too.

I'm pretty sure this will come back to bite us in the ass... If we are
going to change the lazy create/exit setup, I would greatly prefer
doing it at fs mount time (or something to that effect).

-- 
Jens Axboe


  parent reply	other threads:[~2010-07-08 12:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-07 22:52 [PATCH, RFC] simplify writeback thread creation Christoph Hellwig
2010-07-08  7:08 ` Artem Bityutskiy
2010-07-08 12:20 ` Jens Axboe [this message]
2010-07-08 14:21   ` Artem Bityutskiy
2010-07-08 14:59     ` Jens Axboe
2010-07-08 15:23       ` Artem Bityutskiy
2010-07-08 17:23         ` Jens Axboe
2010-07-08 18:43           ` Artem Bityutskiy
2010-07-08 18:48             ` Christoph Hellwig
2010-07-09  7:52               ` Artem Bityutskiy
2010-07-09  8:16                 ` Jens Axboe
2010-07-09 11:06                   ` Theodore Tso
2010-07-09 14:51                 ` Christoph Hellwig
2010-07-09 15:49                   ` Artem Bityutskiy
2010-07-08 13:22 ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C35C292.9020507@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=dedekind1@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).