linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Subject: [PATCH] return EINVAL when thawing unfrozen filesystems
Date: Wed, 28 Jul 2010 14:10:34 -0500	[thread overview]
Message-ID: <4C5080AA.6060206@redhat.com> (raw)

The iterate_supers() loop in do_thaw_all() assumes
that we can call thaw_bdev() until we hit an error; when
I wrote this, we got -EINVAL when requesting a thaw of
an unfrozen bdev.  (it called until error because we
may have nested freezes).

However, commit 4504230a (freeze_bdev: grab active
reference to frozen superblocks) changed this so that
we get a return of 0 in this case, and do_thaw_all()
spins forever when an emergency system-wide thaw
is requested.

It looks to me like the change was inadvertent,
so this patch changes it back.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 99d6af8..51500f6 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -291,7 +291,7 @@ int thaw_bdev(struct block_device *bdev, struct super_block *sb)
 	}
 out:
 	mutex_unlock(&bdev->bd_fsfreeze_mutex);
-	return 0;
+	return error;
 }
 EXPORT_SYMBOL(thaw_bdev);
 


             reply	other threads:[~2010-07-28 19:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28 19:10 Eric Sandeen [this message]
2010-07-29  8:07 ` [PATCH] return EINVAL when thawing unfrozen filesystems Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C5080AA.6060206@redhat.com \
    --to=sandeen@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).