From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH -next] quota: fix QUOTACTL kconfig for gfs2 Date: Thu, 12 Aug 2010 08:39:45 -0700 Message-ID: <4C6415C1.9000905@oracle.com> References: <20100811162435.882687bf.randy.dunlap@oracle.com> <20100812024611.GD14762@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, Steven Whitehouse To: Jan Kara Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:33409 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752766Ab0HLPld (ORCPT ); Thu, 12 Aug 2010 11:41:33 -0400 In-Reply-To: <20100812024611.GD14762@quack.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 08/11/10 19:46, Jan Kara wrote: > On Wed 11-08-10 16:24:35, Randy Dunlap wrote: >> From: Randy Dunlap >> >> warning: (GFS2_FS && BLOCK && EXPERIMENTAL && (64BIT || LBDAF)) selects QUOTACTL which has unmet direct dependencies (XFS_QUOTA || QUOTA) >> >> Signed-off-by: Randy Dunlap >> Cc: Steven Whitehouse >> Cc: cluster-devel@redhat.com >> --- >> fs/quota/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> However, the "depends on" line here seems like overkill to me. > OK, so do you mean that making QUOTACTL default to 'n', removing the > depends on line and letting QUOTA, XFS_QUOTA, and GFS2_QUOTA select > QUOTACTL would be better? Yes, I think that would be better. However, if you like the patch below, we should also kill the 'select QUOTACTL' in fs/gfs2/Kconfig. >> --- linux-next-20100810.orig/fs/quota/Kconfig >> +++ linux-next-20100810/fs/quota/Kconfig >> @@ -65,7 +65,7 @@ config QFMT_V2 >> >> config QUOTACTL >> bool >> - depends on XFS_QUOTA || QUOTA >> + depends on XFS_QUOTA || QUOTA || GFS2_FS >> default y >> >> config QUOTACTL_COMPAT -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***