From: Milan Broz <mbroz@redhat.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: "J. R. Okajima" <hooanon05@yahoo.co.jp>,
linux-fsdevel@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Q. NFS, return value of close(2)
Date: Fri, 13 Aug 2010 14:25:40 +0200 [thread overview]
Message-ID: <4C6539C4.6070907@redhat.com> (raw)
In-Reply-To: <1281546396.3262.7.camel@heimdal.trondhjem.org>
On 08/11/2010 07:06 PM, Trond Myklebust wrote:
>> commit e56f956a08a6227004cd9b7747df6a089dbb3594
>> Author: J. R. Okajima <hooanon05@yahoo.co.jp>
>> Date: Thu Aug 12 02:00:02 2010 +0900
>>
>> NFS: fix the return value of nfs_file_fsync()
>>
>> By the commit
>> af7fa16 2010-08-03 NFS: Fix up the fsync code
>> close(2) became returning the non-zero value even if it went well.
>> nfs_file_fsync() should return 0 when "status" is positive.
>>
>> Signed-off-by: J. R. Okajima <hooanon05@yahoo.co.jp>
Hi,
please can you send this patch to Linus' tree?
NFS is currently broken, so it will save time for people trying
to bisect the problem.
It breaks even elementary operation on nfs mounts
# cat a > b
cat: write error
Patch above from nfs-git fixed the problem for me
http://git.linux-nfs.org/?p=trondmy/nfs-2.6.git;a=commitdiff;h=0702099bd86c33c2dcdbd3963433a61f3f503901
Thanks,
Milan
--
mbroz@redhat.com
prev parent reply other threads:[~2010-08-13 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 15:36 Q. NFS, return value of close(2) J. R. Okajima
2010-08-11 16:31 ` Trond Myklebust
2010-08-11 17:04 ` J. R. Okajima
2010-08-11 17:06 ` Trond Myklebust
2010-08-13 12:25 ` Milan Broz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6539C4.6070907@redhat.com \
--to=mbroz@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=hooanon05@yahoo.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).