From mboxrd@z Thu Jan 1 00:00:00 1970 From: Milan Broz Subject: Re: Q. NFS, return value of close(2) Date: Fri, 13 Aug 2010 14:25:40 +0200 Message-ID: <4C6539C4.6070907@redhat.com> References: <4387.1281540989@jrobl> <1281544299.3262.2.camel@heimdal.trondhjem.org> <7396.1281546264@jrobl> <1281546396.3262.7.camel@heimdal.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "J. R. Okajima" , linux-fsdevel@vger.kernel.org, Linux Kernel Mailing List To: Trond Myklebust Return-path: In-Reply-To: <1281546396.3262.7.camel@heimdal.trondhjem.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 08/11/2010 07:06 PM, Trond Myklebust wrote: >> commit e56f956a08a6227004cd9b7747df6a089dbb3594 >> Author: J. R. Okajima >> Date: Thu Aug 12 02:00:02 2010 +0900 >> >> NFS: fix the return value of nfs_file_fsync() >> >> By the commit >> af7fa16 2010-08-03 NFS: Fix up the fsync code >> close(2) became returning the non-zero value even if it went well. >> nfs_file_fsync() should return 0 when "status" is positive. >> >> Signed-off-by: J. R. Okajima Hi, please can you send this patch to Linus' tree? NFS is currently broken, so it will save time for people trying to bisect the problem. It breaks even elementary operation on nfs mounts # cat a > b cat: write error Patch above from nfs-git fixed the problem for me http://git.linux-nfs.org/?p=trondmy/nfs-2.6.git;a=commitdiff;h=0702099bd86c33c2dcdbd3963433a61f3f503901 Thanks, Milan -- mbroz@redhat.com