From: "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] [fs/9p] Fix NULL point deref in v9fs_dir_release
Date: Tue, 17 Aug 2010 11:37:43 -0700 [thread overview]
Message-ID: <4C6AD6F7.7060507@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100817171331.GA26467@infradead.org>
Christoph Hellwig wrote:
> On Tue, Aug 17, 2010 at 10:19:01AM -0700, Venkateswararao Jujjuri (JV) wrote:
>> There are situations in VFS where we endup calling v9fs_dir_release() before
>> even we instantiate the filp. Hence the check.
>
> Err, what callchain would that be? This really should not happen.
>
Call Trace:
[<ffffffff81209cb1>] v9fs_dir_release+0x29/0x2f
[<ffffffff81105985>] fput+0x13a/0x1ec
[<ffffffff81207e97>] ? v9fs_open_created+0x0/0xd
[<ffffffff811031bd>] __dentry_open+0x1d3/0x29e
[<ffffffff811033d3>] lookup_instantiate_filp+0x6b/0x8c
[<ffffffff81208fc6>] v9fs_vfs_create_dotl+0x1a7/0x20d
[<ffffffff8110e30a>] vfs_create+0x70/0x92
[<ffffffff8110eddc>] do_last+0x2e0/0x605
[<ffffffff8110f553>] do_filp_open+0x1f8/0x5f8
[<ffffffff811019e7>] ? mem_cgroup_charge_common+0x6a/0x7a
[<ffffffff8125e933>] ? might_fault+0x21/0x23
[<ffffffff8125ea32>] ? __strncpy_from_user+0x1e/0x49
[<ffffffff81118ec2>] ? alloc_fd+0x7b/0x124
[<ffffffff81102ef2>] do_sys_open+0x63/0x10f
[<ffffffff81102fd1>] sys_open+0x20/0x22
[<ffffffff81009c32>] system_call_fastpath+0x16/0x1b
prev parent reply other threads:[~2010-08-17 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 17:19 [PATCH] [fs/9p] Fix NULL point deref in v9fs_dir_release Venkateswararao Jujjuri (JV)
2010-08-17 17:13 ` Christoph Hellwig
2010-08-17 18:37 ` Venkateswararao Jujjuri (JV) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6AD6F7.7060507@linux.vnet.ibm.com \
--to=jvrao@linux.vnet.ibm.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).