From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 26/30] ext4: do not send discards as barriers Date: Thu, 26 Aug 2010 10:25:47 +0200 Message-ID: <4C76250B.6060800@kernel.org> References: <1282751267-3530-1-git-send-email-tj@kernel.org> <1282751267-3530-27-git-send-email-tj@kernel.org> <20100825155842.GA3229@lst.de> <20100825160032.GC3229@lst.de> <4C753D75.2010305@kernel.org> <20100825200223.GE2738@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , jaxboe@fusionio.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, linux-raid@vger.kernel.org, James.Bottomley@suse.de, tytso@mit.edu, chris.mason@oracle.com, swhiteho@redhat.com, konishi.ryusuke@lab.ntt.co.jp, dm-devel@redhat.com, vst@vlnb.net, rwheeler@redhat.com, hare@suse.de, neilb@suse.de, rusty@rustcorp.com.au, mst@redhat.com, jeremy@goop.org, snitzer@redhat.com, k-ueda@ct.jp.nec.com, Christoph Hellwig To: Jan Kara Return-path: In-Reply-To: <20100825200223.GE2738@quack.suse.cz> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 08/25/2010 10:02 PM, Jan Kara wrote: > On Wed 25-08-10 17:57:41, Tejun Heo wrote: >> On 08/25/2010 06:00 PM, Christoph Hellwig wrote: >>> On Wed, Aug 25, 2010 at 05:58:42PM +0200, Christoph Hellwig wrote: >>>> On Wed, Aug 25, 2010 at 05:47:43PM +0200, Tejun Heo wrote: >>>>> From: Christoph Hellwig >>>>> >>>>> ext4 already uses synchronous discards, no need to add I/O barriers. >>>> >>>> This needs the patch that Jan sent in reply to my initial version merged >>>> into it. >>> >>> Actually the jbd2 patch needs it merged, but the point still stands. >> >> Yeah, wasn't sure about that one. Has anyone tested it? I'll be >> happy to merge it but I have no idea whether it's correct or not and >> Jan didn't seem to have tested it so... Jan, shall I merge the patch? > I'm quite confident the patch is correct so you can merge it I think but > tomorrow I'll give it some crash testing together with the rest of your > patch set in KVM to be sure. Patch included in the series before jbd2 conversion patch. Thanks. -- tejun