From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Venkateswararao Jujjuri (JV)" Subject: Re: [V9fs-developer] [PATCH 2/3] fs/9p: Add missing iput in v9fs_vfs_lookup Date: Tue, 05 Oct 2010 16:29:01 -0700 Message-ID: <4CABB4BD.6050705@linux.vnet.ibm.com> References: <1286298090-2422-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1286298090-2422-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: "Aneesh Kumar K.V" Return-path: In-Reply-To: <1286298090-2422-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 10/5/2010 10:01 AM, Aneesh Kumar K.V wrote: > Make sure we drop inode reference in the error path > > Signed-off-by: Aneesh Kumar K.V Looks good to me. Reviewed-by : Venkateswararao Jujjuri > --- > fs/9p/vfs_inode.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c > index 1ec9075..1ac9229 100644 > --- a/fs/9p/vfs_inode.c > +++ b/fs/9p/vfs_inode.c > @@ -1028,7 +1028,7 @@ static struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry, > > result = v9fs_fid_add(dentry, fid); > if (result< 0) > - goto error; > + goto error_iput; > > inst_out: > if (v9ses->cache) > @@ -1039,6 +1039,8 @@ inst_out: > d_add(dentry, inode); > return NULL; > > +error_iput: > + iput(inode); > error: > p9_client_clunk(fid); >