From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Stroetmann Subject: Re: [PATCH 01/20] fs: switch bdev inode bdi's correctly Date: Tue, 19 Oct 2010 01:52:26 +0200 Message-ID: <4CBCDDBA.5080304@ontolinux.com> References: <1287382856-29529-1-git-send-email-david@fromorbit.com> <1287382856-29529-2-git-send-email-david@fromorbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-fsdevel To: Dave Chinner Return-path: Received: from moutng.kundenserver.de ([212.227.126.171]:65027 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932155Ab0JRXyX (ORCPT ); Mon, 18 Oct 2010 19:54:23 -0400 In-Reply-To: <1287382856-29529-2-git-send-email-david@fromorbit.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Aloha Mastercoders Don't panic, I only found some typos. On the 18.10.2010 08:20, Dave Chinner wrote: > From: Dave Chinner > > bdev inodes can remain dirty even after their last close. Hence the > BDI associated with the bdev->inode gets modified duringthe last > close to point to the default BDI. However, the bdev inode still > needs to be moved to the dirty lists of the new BDI, otherwise it > will corrupt the writeback list is was left on. > > Add a new function bdev_inode_switch_bdi() to move all the bdi state > from the old bdi to the new one safely. This is only a temporary > measure until the bdev inode<->bdi lifecycle problems are sorted > out. > > Signed-off-by: Dave Chinner > Reviewed-by: Christoph Hellwig > --- > fs/block_dev.c | 26 +++++++++++++++++++++----- > 1 files changed, 21 insertions(+), 5 deletions(-) > > diff --git a/fs/block_dev.c b/fs/block_dev.c > index 50e8c85..501eab5 100644 > --- a/fs/block_dev.c > +++ b/fs/block_dev.c > @@ -48,6 +48,21 @@ inline struct block_device *I_BDEV(struct inode *inode) > > EXPORT_SYMBOL(I_BDEV); > > +/* > + * move the inode from it's current bdi to the a new bdi. if the inode is dirty to the new bdi. If or to a new bdi. If > + * we need to move it onto the dirty list of @dst so that the inode is always > + * on the right list. > + */ [...] The bar is opened Christian Stroetmann