From: Jens Axboe <jaxboe@fusionio.com>
To: Nicolas Kaiser <nikai@nikai.net>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs: return error on error condition
Date: Thu, 21 Oct 2010 11:20:51 +0200 [thread overview]
Message-ID: <4CC005F3.3080500@fusionio.com> (raw)
In-Reply-To: <20101020165047.09150171@absol.kitzblitz>
On 2010-10-20 16:50, Nicolas Kaiser wrote:
> It's intended to return an error, right?
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> ---
> fs/pipe.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/pipe.c b/fs/pipe.c
> index 279eef9..37eb1eb 100644
> --- a/fs/pipe.c
> +++ b/fs/pipe.c
> @@ -382,7 +382,7 @@ pipe_read(struct kiocb *iocb, const struct iovec *_iov,
> error = ops->confirm(pipe, buf);
> if (error) {
> if (!ret)
> - error = ret;
> + ret = error;
> break;
> }
>
Thanks, that is indeed a bug. I'll commit and mark for stable.
--
Jens Axboe
prev parent reply other threads:[~2010-10-21 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 14:50 [PATCH] fs: return error on error condition Nicolas Kaiser
2010-10-21 9:16 ` Américo Wang
2010-10-21 9:20 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC005F3.3080500@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikai@nikai.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).