From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Stroetmann Subject: Re: [PATCH 3/4] fs: skip I_FREEING inodes in writeback_sb_inodes Date: Sun, 24 Oct 2010 23:46:04 +0200 Message-ID: <4CC4A91C.3040401@ontolinux.com> References: <20101024174024.GA2718@lst.de> <20101024174046.GC2718@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-fsdevel To: Christoph Hellwig Return-path: Received: from moutng.kundenserver.de ([212.227.126.186]:56049 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755709Ab0JXVrq (ORCPT ); Sun, 24 Oct 2010 17:47:46 -0400 In-Reply-To: <20101024174046.GC2718@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: little typos On the 24.10.2010 19:40, Christoph Hellwig wrote: > Skip I_FREEING inodes just like I_WILL_FREE and I_NEW when walking the > writeback lists. Currenly this can't happen, but once we move from > inode_lock to more fine grained locking we can have an inode that's > still on the writeback lists but has I_FREEING set, and we absolutely > need to skip it here, just like we do for all other inode list walks. > > Based on a patch from Dave Chinner. > > Signed-off-by: Christoph Hellwig > > Index: linux-2.6/fs/fs-writeback.c > =================================================================== > --- linux-2.6.orig/fs/fs-writeback.c 2010-10-24 13:21:18.282010741 +0200 > +++ linux-2.6/fs/fs-writeback.c 2010-10-24 13:21:35.456004735 +0200 > @@ -487,10 +487,16 @@ static int writeback_sb_inodes(struct su > return 0; > } > > - if (inode->i_state& (I_NEW | I_WILL_FREE)) { > + /* > + * Don't bother with new inodes or inodes beeing freed, first being > + * kind does not need peridic writeout yet, and for the latter > + * kind writeout is handled by the freer. don't know: freer inode or releaser [...]