From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH 4/9] Add yaffs ecc, mtd access and nand abstraction code
Date: Wed, 03 Nov 2010 10:05:13 -0700
Message-ID: <4CD19649.9060300@caviumnetworks.com>
References: <1288803204-3849-1-git-send-email-cdhmanning@gmail.com> <1288803204-3849-5-git-send-email-cdhmanning@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
To: cdhmanning@gmail.com
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1288803204-3849-5-git-send-email-cdhmanning@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On 11/03/2010 09:53 AM, cdhmanning@gmail.com wrote:
> From: Charles Manning<cdhmanning@gmail.com>
[...]
> --- /dev/null
> +++ b/fs/yaffs2/yaffs_ecc.c
[...]
> +
> +/* Count the bits in an unsigned char or a U32 */
> +
> +static int yaffs_count_bits(unsigned char x)
> +{
> +	int r = 0;
> +	while (x) {
> +		if (x&  1)
> +			r++;
> +		x>>= 1;
> +	}
> +	return r;
> +}
> +
> +static int yaffs_count_bits32(unsigned x)
> +{
> +	int r = 0;
> +	while (x) {
> +		if (x&  1)
> +			r++;
> +		x>>= 1;
> +	}
> +	return r;
> +}
> +

These two can probably be replaced with the standard hweight32() and 
hweight8().

David Daney