From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zan Lynx Subject: Re: [PATCH] clear PageError bit in msync & fsync Date: Tue, 09 Nov 2010 14:21:31 -0700 Message-ID: <4CD9BB5B.2090206@acm.org> References: <20101109114422.3918e7f6@annuminas.surriel.com> <20101109142109.224267d0@corrin.poochiereds.net> <4CD9A209.6070807@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Jeff Layton , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, esandeen@redhat.com, jmoyer@redhat.com, linux-fsdevel@vger.kernel.org To: Rik van Riel Return-path: In-Reply-To: <4CD9A209.6070807@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 11/9/10 12:33 PM, Rik van Riel wrote: > On 11/09/2010 02:21 PM, Jeff Layton wrote: > >> This does leave the page in sort of a funky state. The uptodate bit >> will still probably be set, but the dirty bit won't be. The page will >> be effectively "disconnected" from the backing store until someone >> writes to it. >> >> I suppose though that this is the best that can reasonably be done in >> this situation however... > > I spent a few days looking for alternatives, and indeed I found > nothing better... Just an off the top of my head crazy idea... Could you leave the error bit set on the page and treat it as a dirty bit during a future msync, clearing the error bit at that point. The general idea would be to leave the error set unless an explicit write was requested. -- Zan Lynx zlynx@acm.org "Knowledge is Power. Power Corrupts. Study Hard. Be Evil."