From: Rik van Riel <riel@redhat.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Ted Ts'o" <tytso@mit.edu>,
linux-kernel@vger.kernel.org, esandeen@redhat.com,
jmoyer@redhat.com, linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
lmcilroy@redhat.com
Subject: Re: [PATCH] clear PageError bit in msync & fsync
Date: Fri, 12 Nov 2010 12:04:47 -0500 [thread overview]
Message-ID: <4CDD73AF.8070505@redhat.com> (raw)
In-Reply-To: <20101112105250.75f01670@tlielax.poochiereds.net>
On 11/12/2010 10:52 AM, Jeff Layton wrote:
> Now, process A issues an fsync. He gets an error but his data was
> flushed to disk just fine. Is that also incorrect behavior?
I suspect it is better for fsync to return an error when
it wasn't process A's error (but there was an error), than
to pretend everything was just fine when in fact an error
did happen.
When getting an error, the program can retry the write
(to redirty the pages) and retry the IO by calling fsync
again.
If no real error happened, at worst it gets to do the
IO twice.
--
All rights reversed
next prev parent reply other threads:[~2010-11-12 17:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 16:44 [PATCH] clear PageError bit in msync & fsync Rik van Riel
2010-11-09 18:09 ` Valerie Aurora
2010-11-09 19:21 ` Jeff Layton
2010-11-09 19:33 ` Rik van Riel
2010-11-09 21:07 ` Ted Ts'o
2010-11-09 21:15 ` Rik van Riel
2010-11-09 21:41 ` Andrew Morton
2010-11-12 4:36 ` Rik van Riel
2010-11-12 15:52 ` Jeff Layton
2010-11-12 17:04 ` Rik van Riel [this message]
2010-11-09 21:44 ` Jan Kara
2010-11-11 16:31 ` Rik van Riel
2010-11-09 21:21 ` Zan Lynx
2010-11-09 21:24 ` Rik van Riel
2010-11-12 20:51 ` Eric Sandeen
2010-11-12 21:36 ` Jeff Layton
2010-11-09 21:39 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDD73AF.8070505@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=esandeen@redhat.com \
--cc=jlayton@redhat.com \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lmcilroy@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).