From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Quigley Subject: Re: [PATCH] fs: call security_d_instantiate in d_obtain_alias Date: Fri, 19 Nov 2010 00:28:09 -0500 Message-ID: <4CE60AE9.2070101@countercultured.net> References: <1290016263-1637-1-git-send-email-josef@redhat.com> <20101117191817.GA26575@fieldses.org> <20101117192822.GB3818@localhost.localdomain> <20101117202617.GA31009@fieldses.org> <1290031941.14282.101.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "J. Bruce Fields" , Josef Bacik , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, sds@tycho.nsa.gov, selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org To: Eric Paris Return-path: Received: from countercultured.net ([209.51.175.25]:44285 "HELO countercultured.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750832Ab0KSFez (ORCPT ); Fri, 19 Nov 2010 00:34:55 -0500 In-Reply-To: <1290031941.14282.101.camel@localhost.localdomain> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: [snip] > If you have persistent xattr support we need the dentry since the xattr > code requires a dentry. I have no idea why but that's what > inode->i_op->getxattr() requires. > The original reason that the xattr operations take dentries is because of p9fs and CIFS. CIFS uses the name of the file to grab the extended attributes and so does p9fs. I had tried to remove this a while ago but couldn't find a way around that. When trying to find a solution I also got push back from Miklos (FUSE) as he views a filesystem being able to make xattr decisions based on the path name being a valid use-case. Dave