From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Cc: Cezary Sliwa <sliwa@blue.cft.edu.pl>
Subject: [PATCH] ext2: include fs.h in ext2_fs.h
Date: Fri, 03 Dec 2010 10:26:26 -0600 [thread overview]
Message-ID: <4CF91A32.6080706@redhat.com> (raw)
As reported by Cezary Sliwa in
https://bugzilla.kernel.org/show_bug.cgi?id=24282
ext2_fs.h references FS_DIRSYNC_FL etc, but does not
include <linux/fs.h> to define them. This seems ok
for kernelspace builds, but breaks userspace applications
which include ext2_fs.h.
Reported-by: Cezary Sliwa <sliwa@blue.cft.edu.pl>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/include/linux/ext2_fs.h b/include/linux/ext2_fs.h
index 2dfa707..91f90e4 100644
--- a/include/linux/ext2_fs.h
+++ b/include/linux/ext2_fs.h
@@ -16,6 +16,7 @@
#ifndef _LINUX_EXT2_FS_H
#define _LINUX_EXT2_FS_H
+#include <linux/fs.h>
#include <linux/types.h>
#include <linux/magic.h>
next reply other threads:[~2010-12-03 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 16:26 Eric Sandeen [this message]
2010-12-03 18:20 ` [PATCH] ext2: include fs.h in ext2_fs.h Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF91A32.6080706@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sliwa@blue.cft.edu.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).