From: Jens Axboe <jaxboe@fusionio.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Neil Brown <neilb@suse.de>
Subject: Re: [PATCH] fs/splice: Pull buf->ops->confirm() from splice_from_pipe actors
Date: Mon, 13 Dec 2010 14:38:19 +0100 [thread overview]
Message-ID: <4D0621CB.2010809@fusionio.com> (raw)
In-Reply-To: <17eaa416d82b1c57f70443e56ad22feb3c3a3a6f.1292184347.git.mirq-linux@rere.qmqm.pl>
On 2010-12-12 22:23, Michał Mirosław wrote:
> This patch pulls calls to buf->ops->confirm() from all actors passed
> (also indirectly) to splice_from_pipe_feed().
Why? The point of ->confirm() is to ensure that the contents are
stable, otherwise the pages in the pipe could merely be in flight.
It's needed if you need to actually look at the data, rather than just
reference it.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-12-13 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-12 21:23 [PATCH] fs/splice: Pull buf->ops->confirm() from splice_from_pipe actors Michał Mirosław
2010-12-13 13:38 ` Jens Axboe [this message]
2010-12-13 15:04 ` Michał Mirosław
2010-12-14 20:12 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0621CB.2010809@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=bfields@fieldses.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=neilb@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).