From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH] fs/splice: Pull buf->ops->confirm() from splice_from_pipe actors Date: Mon, 13 Dec 2010 14:38:19 +0100 Message-ID: <4D0621CB.2010809@fusionio.com> References: <17eaa416d82b1c57f70443e56ad22feb3c3a3a6f.1292184347.git.mirq-linux@rere.qmqm.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Alexander Viro , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "J. Bruce Fields" , Neil Brown To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Return-path: Received: from mx1.fusionio.com ([64.244.102.30]:59133 "EHLO mx1.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752831Ab0LMNiW (ORCPT ); Mon, 13 Dec 2010 08:38:22 -0500 In-Reply-To: <17eaa416d82b1c57f70443e56ad22feb3c3a3a6f.1292184347.git.mirq-linux@rere.qmqm.pl> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 2010-12-12 22:23, Micha=C5=82 Miros=C5=82aw wrote: > This patch pulls calls to buf->ops->confirm() from all actors passed > (also indirectly) to splice_from_pipe_feed(). Why? The point of ->confirm() is to ensure that the contents are stable, otherwise the pages in the pipe could merely be in flight. It's needed if you need to actually look at the data, rather than just reference it. --=20 Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html