From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Stornelli Subject: Re: Return value of generic xattr operations Date: Mon, 27 Dec 2010 09:38:03 +0100 Message-ID: <4D18506B.8070400@gmail.com> References: <4D1748D4.5050700@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Linux FS Devel , Linux Kernel To: Olaf van der Spek Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:58347 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752430Ab0L0Ilp (ORCPT ); Mon, 27 Dec 2010 03:41:45 -0500 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Il 26/12/2010 22:15, Olaf van der Spek ha scritto: > On Sun, Dec 26, 2010 at 2:53 PM, Marco Stornelli > wrote: >> Hi, >> >> is it right that generic_setxattr & co. return -EOPNOTSUPP if there is a >> namespace error? I mean, if the user try to set .foo >> attribute, the return value should be -EINVAL, isn't it? Operation not > > Why? > There are multiple errors and only one can be returned. > Ok, but at least it should be return the most important. Man page said: "If extended attributes are not supported by the file system, or are disabled, errno is set to ENOTSUP.", but in this case this kind of error is not really matching with this sentence, because the extended attribute are supported by fs and they are enabled. Marco