From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marco Stornelli <marco.stornelli@gmail.com>
Subject: Re: [PATCH] fs: FS_POSIX_ACL does not depend on BLOCK
Date: Sun, 02 Jan 2011 10:39:18 +0100
Message-ID: <4D2047C6.6080007@gmail.com>
References: <20110101221716.70ef7f5a.randy.dunlap@oracle.com> <20110102062948.GA582@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	linux-fsdevel@vger.kernel.org, akpm <akpm@linux-foundation.org>,
	viro <viro@zeniv.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-wy0-f174.google.com ([74.125.82.174]:33348 "EHLO
	mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751176Ab1ABJnM (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sun, 2 Jan 2011 04:43:12 -0500
Received: by wyb28 with SMTP id 28so12642554wyb.19
        for <linux-fsdevel@vger.kernel.org>; Sun, 02 Jan 2011 01:43:10 -0800 (PST)
In-Reply-To: <20110102062948.GA582@infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Il 02/01/2011 07:29, Christoph Hellwig ha scritto:
> On Sat, Jan 01, 2011 at 10:17:16PM -0800, Randy Dunlap wrote:
>> +config FS_POSIX_ACL
>> +# Posix ACL utility routines
>> +# (for now, ext2/ext3/ext4/jfs/jffs2/reiserfs/xfs/btrfs/gfs2/ocfs2/nfs4/9p)
>> +#
>> +# NOTE: you can implement Posix ACLs without these helpers.
>> +# 	Never use this symbol for ifdefs.
>> +#
>> +	def_bool n
>> +
> 
> I'd drop the list of filesystems, and move the comment above the symbol,
> e.g:
> 
> #
> # Posix ACL utility routines
> #
> # Note: Posix ACLs can be implemented without these helpers.  Never use
> # this symbol for ifdefs in core code.
> #
> config FS_POSIX_ACL
> 	def_bool n
> 

I agree, the list can be a maintaince overhead.

Marco