From mboxrd@z Thu Jan 1 00:00:00 1970 From: Milan Broz Subject: Re: linux-next - WARNING: at fs/block_dev.c:824 bd_link_disk_holder+0x92/0x1ac() Date: Thu, 13 Jan 2011 01:23:45 +0100 Message-ID: <4D2E4611.90002@redhat.com> References: <16069.1294853673@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Alexander Viro , Neil Brown , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org, device-mapper development , Tejun Heo To: Valdis.Kletnieks@vt.edu Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56807 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754892Ab1AMAYO (ORCPT ); Wed, 12 Jan 2011 19:24:14 -0500 In-Reply-To: <16069.1294853673@localhost> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 01/12/2011 06:34 PM, Valdis.Kletnieks@vt.edu wrote: > Seen in a boot of yesterday's linux-next. The 'W' flag was due to the > already-reported 'WARNING: at kernel/workqueue.c:1202 worker_enter_idle'. > Not sure if it's a block_dev or dm/LVM issue, so I'm cc:'ing both groups. I wonder > if the fact I still have 'CONFIG_DEVTMPFS=n' is involved (it's apparently ticking off > dracut before and after the warning). > > [ 16.840333] dracut: Found volume group "vg_blackice" using metadata type lvm2 > [ 16.892282] dracut: The link /dev/vg_blackice/opt should had been created by udev but it was not found. Falling back to direct link creation. > [ 16.912627] ------------[ cut here ]------------ > [ 16.912635] WARNING: at fs/block_dev.c:824 bd_link_disk_holder+0x92/0x1ac() That seems to be WARN_ON_ONCE(!bdev->bd_holder || bdev->bd_holder_disk); added in patch http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=e09b457bdb7e8d23fc54dcef0930ac697d8de895 "block: simplify holder symlink handling" dm linear just claims device in table constructor, I don't think it is bug in DM code. > [ 16.912638] Hardware name: Latitude E6500 > [ 16.912640] Modules linked in: > [ 16.912644] Pid: 1920, comm: lvm Tainted: G W 2.6.37-next-20110111 #1 > [ 16.912647] Call Trace: > [ 16.912653] [] ? warn_slowpath_common+0x80/0x98 > [ 16.912657] [] ? warn_slowpath_null+0x15/0x17 > [ 16.912660] [] ? bd_link_disk_holder+0x92/0x1ac > [ 16.912665] [] ? open_dev+0x76/0x9e > [ 16.912668] [] ? dm_get_device+0x147/0x1dc > [ 16.912672] [] ? linear_ctr+0x98/0xd4 > [ 16.912676] [] ? dm_table_add_target+0x149/0x1d4 > [ 16.912679] [] ? table_load+0xf0/0x27b > [ 16.912683] [] ? table_load+0x0/0x27b > [ 16.912686] [] ? ctl_ioctl+0x1c6/0x21e > [ 16.912690] [] ? dm_ctl_ioctl+0xe/0x12 > [ 16.912695] [] ? do_vfs_ioctl+0x4c4/0x505 > [ 16.912699] [] ? sys_ioctl+0x57/0x95 > [ 16.912703] [] ? system_call_fastpath+0x16/0x1b > [ 16.912706] ---[ end trace 4eaa2a86a8e2da24 ]--- > [ 16.925289] dracut: The link /dev/vg_blackice/src should had been created by udev but it was not found. Falling back to direct link creation. > Milan