From mboxrd@z Thu Jan 1 00:00:00 1970 From: Milan Broz Subject: Re: [dm-devel] linux-next - WARNING: at fs/block_dev.c:824 bd_link_disk_holder+0x92/0x1ac() Date: Thu, 13 Jan 2011 14:58:23 +0100 Message-ID: <4D2F04FF.1070309@redhat.com> References: <16069.1294853673@localhost> <4D2E4611.90002@redhat.com> <4D2E6129.8000700@ce.jp.nec.com> <20110113110640.GC30719@htj.dyndns.org> <4D2EE156.1050006@redhat.com> <20110113122701.GG16523@nb.net.home> <20110113131216.GF30719@htj.dyndns.org> <20110113132637.GH16523@nb.net.home> <20110113133722.GG30719@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Karel Zak , device-mapper development , "Jun'ichi Nomura" , Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, Alexander Viro , linux-fsdevel@vger.kernel.org, Kay Sievers To: Tejun Heo Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50782 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756768Ab1AMN6h (ORCPT ); Thu, 13 Jan 2011 08:58:37 -0500 In-Reply-To: <20110113133722.GG30719@htj.dyndns.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 01/13/2011 02:37 PM, Tejun Heo wrote: > So, just don't do it. Sysfs is for device hierarchy. Don't try to > shove pretty looking things there (unless it's something widely agreed > on and necessary, of course). Hi, I think that it is exactly what holders/slaves do - displaying device hierarchy. So application can check which underlying device are related and ask them for more info if needed (=> with system specific call, it can be simple sysfs attribute, ioctl, whatever). So the only request here is to keep these symlinks correct, nothing more. Or am I missing anything? Milan