From mboxrd@z Thu Jan 1 00:00:00 1970 From: Milan Broz Subject: Re: [dm-devel] linux-next - WARNING: at fs/block_dev.c:824 bd_link_disk_holder+0x92/0x1ac() Date: Thu, 13 Jan 2011 16:03:12 +0100 Message-ID: <4D2F1430.50906@redhat.com> References: <16069.1294853673@localhost> <4D2E4611.90002@redhat.com> <4D2E6129.8000700@ce.jp.nec.com> <20110113110640.GC30719@htj.dyndns.org> <4D2EE156.1050006@redhat.com> <20110113122701.GG16523@nb.net.home> <20110113131216.GF30719@htj.dyndns.org> <20110113132637.GH16523@nb.net.home> <20110113133722.GG30719@htj.dyndns.org> <4D2F04FF.1070309@redhat.com> <20110113141107.GI30719@htj.dyndns.org> <4D2F0B6A.6010201@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Tejun Heo , Karel Zak , device-mapper development , "Jun'ichi Nomura" , Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, Alexander Viro , linux-fsdevel@vger.kernel.org To: Kay Sievers Return-path: Received: from mx1.redhat.com ([209.132.183.28]:57778 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756885Ab1AMPD3 (ORCPT ); Thu, 13 Jan 2011 10:03:29 -0500 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 01/13/2011 03:43 PM, Kay Sievers wrote: >> On Thu, Jan 13, 2011 at 3:25 PM, Milan Broz wrote: >>> Maybe, but this was not invented in DM/MD camp:-) >>> Probably Kay or Greg can answer why it was done this way? > > It's not from Greg or Kay. It just appeared some day in the context of dm. :) ah, then sorry, I am just confused:-) But DM does not need it for operation at all so it must had some other reason. (We have dmsetup ls --tree using dm-ioctls for years.) > And yes, symlinks *look* nice and simple for the outside, but they are > not, and have all sorts of problems like non-atomic updates, make it > impossible to ever rename a device (as long as they copy the device > name), and and and .... we should not add more of this. Yes, I agree, if there is better way, let's switch to that. Milan