From: Milan Broz <mbroz@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>,
Jens Axboe <axboe@kernel.dk>,
Valdis.Kletnieks@vt.edu, Alexander Viro <viro@zeniv.linux.org.uk>,
Neil Brown <neilb@suse.de>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-raid@vger.kernel.org,
device-mapper development <dm-devel@redhat.com>,
Kay Sievers <kay.sievers@vrfy.org>,
Alasdair G Kergon <agk@redhat.com>
Subject: Re: [PATCH UPDATED] block: restore multiple bd_link_disk_holder() support
Date: Fri, 14 Jan 2011 22:09:12 +0100 [thread overview]
Message-ID: <4D30BB78.5020101@redhat.com> (raw)
In-Reply-To: <20110114161043.GB978@htj.dyndns.org>
On 01/14/2011 05:10 PM, Tejun Heo wrote:
> Commit e09b457b (block: simplify holder symlink handling) incorrectly
> assumed that there is only one link at maximum. dm may use multiple
> links and expects block layer to track reference count for each link,
> which is different from and unrelated to the exclusive device holder
> identified by @holder when the device is opened.
>
> Remove the single holder assumption and automatic removal of the link
> and revive the per-link reference count tracking. The code
> essentially behaves the same as before commit e09b457b sans the
> unnecessary kobject reference count dancing.
>
> While at it, note that this facility should not be used by anyone else
> than the current ones. Sysfs symlinks shouldn't be abused like this
> and the whole thing doesn't belong in the block layer at all.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Milan Broz <mbroz@redhat.com>
> Cc: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
> Cc: Neil Brown <neilb@suse.de>
> Cc: linux-raid@vger.kernel.org
> Cc: Kay Sievers <kay.sievers@vrfy.org>
> ---
> Thanks for the test commands. They were very helpful. Can you please
> test this one?
Hi,
yes, this one works for me. I run full lvm2 testsuite and no warnings.
Thanks!
Tested-by: Milan Broz <mbroz@redhat.com>
Milan
next prev parent reply other threads:[~2011-01-14 21:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 17:34 linux-next - WARNING: at fs/block_dev.c:824 bd_link_disk_holder+0x92/0x1ac() Valdis.Kletnieks
2011-01-13 0:23 ` Milan Broz
2011-01-13 2:19 ` Jun'ichi Nomura
2011-01-13 11:06 ` Tejun Heo
2011-01-13 11:26 ` [dm-devel] " Milan Broz
2011-01-13 12:27 ` Karel Zak
2011-01-13 13:12 ` Tejun Heo
2011-01-13 13:26 ` Karel Zak
2011-01-13 13:37 ` Tejun Heo
2011-01-13 13:52 ` Tejun Heo
2011-01-13 13:58 ` Milan Broz
2011-01-13 14:11 ` Tejun Heo
2011-01-13 14:25 ` Milan Broz
2011-01-13 14:30 ` Tejun Heo
2011-01-13 14:43 ` Kay Sievers
2011-01-13 15:03 ` Milan Broz
2011-01-14 7:38 ` Jun'ichi Nomura
2011-01-13 15:59 ` Karel Zak
2011-01-13 16:10 ` [dm-devel] " Kay Sievers
2011-01-14 15:07 ` Karel Zak
2011-01-14 15:23 ` Kay Sievers
2011-01-13 14:45 ` Theodore Tso
2011-01-13 20:18 ` NeilBrown
2011-01-13 20:41 ` Ted Ts'o
2011-01-14 16:20 ` Tejun Heo
[not found] ` <20110114162022.GC978@htj.dyndns.org>
2011-01-14 17:59 ` Ted Ts'o
2011-01-14 18:23 ` Tejun Heo
2011-01-13 14:49 ` Milan Broz
2011-01-14 16:35 ` Tejun Heo
2011-01-13 17:21 ` [PATCH] block: restore multiple bd_link_disk_holder() support Tejun Heo
2011-01-13 18:42 ` Milan Broz
2011-01-14 7:31 ` Jun'ichi Nomura
2011-01-14 16:10 ` [PATCH UPDATED] " Tejun Heo
2011-01-14 21:09 ` Milan Broz [this message]
2011-01-17 0:18 ` Jun'ichi Nomura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D30BB78.5020101@redhat.com \
--to=mbroz@redhat.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).