From: Ryan Mallon <ryan@bluewatersys.com>
To: David Daney <ddaney@caviumnetworks.com>
Cc: Charles Manning <cdhmanning@gmail.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 01/10] Add yaffs2 file system: Allocation, block handling and bitmapping code
Date: Fri, 21 Jan 2011 08:46:25 +1300 [thread overview]
Message-ID: <4D389111.4000206@bluewatersys.com> (raw)
In-Reply-To: <4D374B9A.3040002@caviumnetworks.com>
On 01/20/2011 09:37 AM, David Daney wrote:
> On 01/19/2011 12:25 PM, Ryan Mallon wrote:
>> On 01/14/2011 04:06 PM, Charles Manning wrote:
> [...]
>>> + if (!allocator) {
>>> + YBUG();
>>> + return;
>>> + }
>>
>> You don't need this bug, the dereference of allocator below will oops
>> with all the same information as bug.
>>
>
> Is that true for nommu systems too?
Actually, I'm not too sure. I understood that best practice was to avoid
putting BUG in places that will normally oops. Maybe someone can shed
some light on this?
~Ryan
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan@bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
next prev parent reply other threads:[~2011-01-20 19:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 3:05 [PATCH 0/10] Add yaffs2 file system: Fourth patchset Charles Manning
2011-01-14 3:06 ` [PATCH 01/10] Add yaffs2 file system: Allocation, block handling and bitmapping code Charles Manning
2011-01-19 20:25 ` Ryan Mallon
2011-01-19 20:37 ` David Daney
2011-01-20 19:46 ` Ryan Mallon [this message]
2011-01-14 3:06 ` [PATCH 02/10] Add yaffs2 file system: Attribute and xattrib handling code Charles Manning
2011-01-19 20:37 ` Ryan Mallon
2011-01-14 3:06 ` [PATCH 03/10] Add yaffs2 file system: Checkpoint handing code Charles Manning
2011-01-19 21:47 ` Ryan Mallon
2011-01-14 3:06 ` [PATCH 04/10] Add yaffs2 file system: Flash interfacing and ECC handling code Charles Manning
2011-01-19 23:27 ` Ryan Mallon
2011-01-14 3:06 ` [PATCH 05/10] Add yaffs2 file system: Tags processing code Charles Manning
2011-01-20 0:07 ` Ryan Mallon
2011-01-14 3:06 ` [PATCH 06/10] Add yaffs2 file system: Tracing and verification code Charles Manning
2011-01-20 0:30 ` Ryan Mallon
2011-01-14 3:06 ` [PATCH 07/10] Add yaffs2 file system: yaffs1 and yaffs2 mode specific code Charles Manning
2011-01-20 4:19 ` Ryan Mallon
2011-01-14 3:06 ` [PATCH 08/10] Add yaffs2 file system: Core guts code Charles Manning
2011-01-14 3:06 ` [PATCH 09/10] Add yaffs2 file system: Linux glue code Charles Manning
2011-01-20 20:14 ` Jesper Juhl
2011-01-20 21:26 ` Ryan Mallon
2011-01-14 3:06 ` [PATCH 10/10] Add yaffs2 file system: Hook in to Linux tree Charles Manning
2011-01-20 20:32 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D389111.4000206@bluewatersys.com \
--to=ryan@bluewatersys.com \
--cc=akpm@linux-foundation.org \
--cc=cdhmanning@gmail.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).