From: Ryan Mallon <ryan@bluewatersys.com>
To: Mandeep Singh Baines <msb@chromium.org>
Cc: gregkh@suse.de, rjw@sisk.pl, mingo@redhat.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-pm@lists.linux-foundation.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/6] mm/page_alloc: use appropriate printk priority level
Date: Thu, 27 Jan 2011 13:32:00 +1300 [thread overview]
Message-ID: <4D40BD00.1090408@bluewatersys.com> (raw)
In-Reply-To: <1296084570-31453-2-git-send-email-msb@chromium.org>
On 01/27/2011 12:29 PM, Mandeep Singh Baines wrote:
> printk()s without a priority level default to KERN_WARNING. To reduce
> noise at KERN_WARNING, this patch set the priority level appriopriately
> for unleveled printks()s. This should be useful to folks that look at
> dmesg warnings closely.
>
> Signed-off-by: Mandeep Singh Baines <msb@chromium.org>
> ---
> @@ -4700,33 +4700,36 @@ void __init free_area_init_nodes(unsigned long *max_zone_pfn)
> find_zone_movable_pfns_for_nodes(zone_movable_pfn);
>
> /* Print out the zone ranges */
> - printk("Zone PFN ranges:\n");
> + printk(KERN_INFO "Zone PFN ranges:\n");
> for (i = 0; i < MAX_NR_ZONES; i++) {
> if (i == ZONE_MOVABLE)
> continue;
> - printk(" %-8s ", zone_names[i]);
> + printk(KERN_INFO " %-8s ", zone_names[i]);
> if (arch_zone_lowest_possible_pfn[i] ==
> arch_zone_highest_possible_pfn[i])
> printk("empty\n");
Should be printk(KERN_CONT ... (or pr_cont).
> else
> - printk("%0#10lx -> %0#10lx\n",
> + printk(KERN_INFO "%0#10lx -> %0#10lx\n",
> arch_zone_lowest_possible_pfn[i],
> arch_zone_highest_possible_pfn[i]);
The printk above doesn't have a trailing newline so this should be
printk(KERN_CONT ...
There are a couple of other places in this patch series that also need
to be fixed in a similar manner.
~Ryan
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan@bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-27 0:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110125235700.GR8008@google.com>
2011-01-26 23:29 ` [PATCH v1 0/6] Set printk priority level Mandeep Singh Baines
2011-01-27 7:22 ` WANG Cong
2011-01-26 23:29 ` [PATCH 1/6] mm/page_alloc: use appropriate " Mandeep Singh Baines
2011-01-27 0:32 ` Ryan Mallon [this message]
2011-01-27 4:22 ` Mandeep Singh Baines
2011-01-27 20:32 ` Ryan Mallon
2011-01-26 23:29 ` [PATCH 2/6] arch/x86: " Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 3/6] PM: " Mandeep Singh Baines
2011-01-31 10:12 ` Rafael J. Wysocki
2011-01-26 23:29 ` [PATCH 4/6] TTY: " Mandeep Singh Baines
2011-02-03 22:13 ` Greg KH
2011-02-06 17:31 ` [PATCH v2] " Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 5/6] fs: " Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 6/6] taskstats: " Mandeep Singh Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D40BD00.1090408@bluewatersys.com \
--to=ryan@bluewatersys.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@redhat.com \
--cc=msb@chromium.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).