From: Boaz Harrosh <bharrosh@panasas.com>
To: open-osd <osd-dev@open-osd.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: [PATCH 1/7] exofs: trivial: fix some indentation and debug prints
Date: Tue, 08 Feb 2011 18:17:26 +0200 [thread overview]
Message-ID: <4D516C96.8070509@panasas.com> (raw)
In-Reply-To: <4D516C1C.8060504@panasas.com>
I stumbled on some of these prints in log files so, might
just submit the fixes.
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
fs/exofs/dir.c | 15 ++++++---------
1 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/fs/exofs/dir.c b/fs/exofs/dir.c
index dcc941d..132721a 100644
--- a/fs/exofs/dir.c
+++ b/fs/exofs/dir.c
@@ -261,9 +261,7 @@ exofs_readdir(struct file *filp, void *dirent, filldir_t filldir)
struct page *page = exofs_get_page(inode, n);
if (IS_ERR(page)) {
- EXOFS_ERR("ERROR: "
- "bad page in #%lu",
- inode->i_ino);
+ EXOFS_ERR("ERROR: bad page in #%lu", inode->i_ino);
filp->f_pos += PAGE_CACHE_SIZE - offset;
return PTR_ERR(page);
}
@@ -282,8 +280,7 @@ exofs_readdir(struct file *filp, void *dirent, filldir_t filldir)
EXOFS_DIR_REC_LEN(1);
for (; (char *)de <= limit; de = exofs_next_entry(de)) {
if (de->rec_len == 0) {
- EXOFS_ERR("ERROR: "
- "zero-length directory entry");
+ EXOFS_ERR("ERROR: zero-length directory entry");
exofs_put_page(page);
return -EIO;
}
@@ -342,9 +339,8 @@ struct exofs_dir_entry *exofs_find_entry(struct inode *dir,
kaddr += exofs_last_byte(dir, n) - reclen;
while ((char *) de <= kaddr) {
if (de->rec_len == 0) {
- EXOFS_ERR(
- "ERROR: exofs_find_entry: "
- "zero-length directory entry");
+ EXOFS_ERR("ERROR: exofs_find_entry: "
+ "zero-length directory entry");
exofs_put_page(page);
goto out;
}
@@ -491,7 +487,8 @@ int exofs_add_link(struct dentry *dentry, struct inode *inode)
exofs_put_page(page);
}
- EXOFS_ERR("exofs_add_link: BAD dentry=%p or inode=%p", dentry, inode);
+ EXOFS_ERR("exofs_add_link: BAD dentry=%p or inode=%lu",
+ dentry, inode->i_ino);
return -EINVAL;
got_it:
--
1.7.2.3
next prev parent reply other threads:[~2011-02-08 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 16:15 [PATCHSET 0/7] exofs: Some pending changes for 2.6.39 Boaz Harrosh
2011-02-08 16:17 ` Boaz Harrosh [this message]
2011-02-08 16:26 ` [PATCH 2/7] exofs: Optimize read_4_write Boaz Harrosh
2011-02-08 16:29 ` [PATCH 3/7] exofs: simple fsync race fix Boaz Harrosh
2011-02-08 16:31 ` [PATCH 4/7] exofs: Override read-ahead to align on stripe_size Boaz Harrosh
2011-02-08 16:35 ` [PATCH 5/7] exofs: Add option to mount by osdname Boaz Harrosh
2011-02-08 16:40 ` [PATCH 6/7] exofs: Write sbi->s_nextid as part of the Create command Boaz Harrosh
2011-02-08 16:42 ` [PATCH 7/7] exofs: deprecate the commands pending counter Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D516C96.8070509@panasas.com \
--to=bharrosh@panasas.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).