From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Mallon Subject: Re: [PATCH 0/10] Add yaffs2 file system: Fifth patchset Date: Fri, 18 Feb 2011 13:55:04 +1300 Message-ID: <4D5DC368.2080003@bluewatersys.com> References: <1297221968-6747-1-git-send-email-cdhmanning@gmail.com> <201102171531.03924.manningc2@actrix.gen.nz> <4D5C8D62.4060809@bluewatersys.com> <201102171649.57457.manningc2@actrix.gen.nz> <20110217234154.GA1474@kroah.com> <20110218000150.GA27668@opensource.wolfsonmicro.com> <20110218003353.GA25386@kroah.com> <20110218004354.GB27668@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Greg KH , Charles Manning , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org To: Mark Brown Return-path: Received: from mail.bluewatersys.com ([202.124.120.130]:13666 "EHLO hayes.bluewaternz.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750942Ab1BRAya (ORCPT ); Thu, 17 Feb 2011 19:54:30 -0500 In-Reply-To: <20110218004354.GB27668@opensource.wolfsonmicro.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 02/18/2011 01:43 PM, Mark Brown wrote: > On Thu, Feb 17, 2011 at 04:33:53PM -0800, Greg KH wrote: >> On Fri, Feb 18, 2011 at 12:01:50AM +0000, Mark Brown wrote: > >>> For the proc stuff - for tracing stuff then tracepoints are likely to be >>> a good option if it's useful to people. > >> Then use the in-kernel tracing functionality, don't roll your own. And >> that is not in /proc, so it should be there for this filesystem either. > > That'd be the tracepoints I was mentioning, then... Are you suggesting that the yaffs_trace function should be replaced with tracepoints? yaffs_trace is basically just a wrapper around printk, which I suggested should be replaced with pr_debug so that it can be compiled out completely. Other drivers and filesystems have similar custom debugging functions. I haven't used tracepoints, but it seems like they are better suited to tracing specific events than as a general printk style debugging replacement? ~Ryan -- Bluewater Systems Ltd - ARM Technology Solution Centre Ryan Mallon 5 Amuri Park, 404 Barbadoes St ryan@bluewatersys.com PO Box 13 889, Christchurch 8013 http://www.bluewatersys.com New Zealand Phone: +64 3 3779127 Freecall: Australia 1800 148 751 Fax: +64 3 3779135 USA 1800 261 2934