From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Stornelli Subject: Re: [PATCH v3][RESEND] Check for immutable/append flag in fallocate path Date: Wed, 09 Mar 2011 20:42:25 +0100 Message-ID: <4D77D821.7090003@gmail.com> References: <4D6221B8.9040303@gmail.com> <4D6F5473.2070709@gmail.com> <4D720469.1010101@gmail.com> <4D720C0B.1050300@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Linux Kernel , Linux FS Devel , Greg Kroah-Hartman To: viro@zeniv.linux.org.uk Return-path: In-Reply-To: <4D720C0B.1050300@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Il 05/03/2011 11:10, Marco Stornelli ha scritto: > From: Marco Stornelli > > In the fallocate path the kernel doesn't check for the immutable/append > flag. It's possible to have a race condition in this scenario: an > application open a file in read/write and it does something, meanwhile > root set the immutable flag on the file, the application at that point > can call fallocate with success. In addition, we don't allow to do any > unreserve operation on an append only file but only the reserve one. > > Signed-off-by: Marco Stornelli Al, can you apply this patch please? I add Greg in cc, because maybe he could be interested about stable tree. Marco