From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felix Fietkau Subject: Re: [PATCH 0/6 v7] overlay filesystem - request for inclusion Date: Tue, 22 Mar 2011 19:22:39 +0100 Message-ID: <4D88E8EF.8000001@openwrt.org> References: <20110322152602.053930811@szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Miklos Szeredi , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, apw@canonical.com, neilb@suse.de To: Linus Torvalds Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 2011-03-22 6:36 PM, Linus Torvalds wrote: > On Tue, Mar 22, 2011 at 8:26 AM, Miklos Szeredi wrote: >> Here's an updated version of the overlay filesystem. I'd like to >> propose it for inclusion into mainline. > > So on the whole it looked pretty small and simple. And most of the VFS > level changes looked fine and I just reacted to the odd calling > convention for open (I really think you should aim for ->open to have > the basically same arguments as you made __dentry_open have: 'struct > path', 'struct filp' and 'struct cred'). > > But I'd want Al's ack on the series. And also hear who uses it and how > it's been tested? We're using it in OpenWrt (an Embedded Linux distribution) for devices with tiny amounts of flash for the entire system (e.g. 4 MB). We're using it to provide a writable on-flash root filesystem with squashfs for the read-only part and jffs2 for the writable overlay. This saves some precious flash space compared to using only jffs2, and it makes it easy for users to reset their device to defaults without having to reflash. With a backport of v6 of this series + my fixes that went into v7 this is working quite well on 2.6.37 and 2.6.38 - I'm using it on a few wireless access points at home. - Felix