From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [Patch V2] proc: check error pointer returned by m_start() Date: Mon, 28 Mar 2011 13:45:18 +0800 Message-ID: <4D90206E.1090307@redhat.com> References: <1301289993-24248-1-git-send-email-amwang@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, WANG Cong , Linus Torvalds , Al Viro , Andrew Morton , Eric B Munson , David Rientjes , Dave Hansen , Mel Gorman , linux-fsdevel@vger.kernel.org To: Amerigo Wang Return-path: In-Reply-To: <1301289993-24248-1-git-send-email-amwang@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org =E4=BA=8E 2011=E5=B9=B403=E6=9C=8828=E6=97=A5 13:26, Amerigo Wang =E5=86= =99=E9=81=93: > From: WANG Cong > > V2: move the check into m_stop() as suggested by Linus, > also, most ->show() implementations assume the second parameter 'v' > is not NULL, this fixes them too. Linus, forget this one, I saw you already checked in your own fix, I will make one based on that. :) Thanks.