From: Jens Axboe <jaxboe@fusionio.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "dushistov@mail.ru" <dushistov@mail.ru>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] ufs: remove unessecary blk_flush_plug
Date: Wed, 30 Mar 2011 12:18:08 +0200 [thread overview]
Message-ID: <4D930360.9050709@fusionio.com> (raw)
In-Reply-To: <20110330095702.GA13726@lst.de>
On 2011-03-30 11:57, Christoph Hellwig wrote:
> We already flush the per-process plugging list when context switching,
> so a blk_flush_plug call just before a yield() is not needed.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs/fs/ufs/truncate.c
> ===================================================================
> --- xfs.orig/fs/ufs/truncate.c 2011-03-30 11:35:58.095660392 +0200
> +++ xfs/fs/ufs/truncate.c 2011-03-30 11:36:03.487659988 +0200
> @@ -479,7 +479,6 @@ int ufs_truncate(struct inode *inode, lo
> break;
> if (IS_SYNC(inode) && (inode->i_state & I_DIRTY))
> ufs_sync_inode (inode);
> - blk_flush_plug(current);
> yield();
> }
Added for .39 merge, thanks.
--
Jens Axboe
prev parent reply other threads:[~2011-03-30 10:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 9:57 [PATCH] ufs: remove unessecary blk_flush_plug Christoph Hellwig
2011-03-30 10:18 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D930360.9050709@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=dushistov@mail.ru \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).