From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jens Axboe <jaxboe@fusionio.com>
Subject: Re: [PATCH] ufs: remove unessecary blk_flush_plug
Date: Wed, 30 Mar 2011 12:18:08 +0200
Message-ID: <4D930360.9050709@fusionio.com>
References: <20110330095702.GA13726@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: "dushistov@mail.ru" <dushistov@mail.ru>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx2.fusionio.com ([64.244.102.31]:35025 "EHLO mx2.fusionio.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755052Ab1C3KSL (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 30 Mar 2011 06:18:11 -0400
In-Reply-To: <20110330095702.GA13726@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 2011-03-30 11:57, Christoph Hellwig wrote:
> We already flush the per-process plugging list when context switching,
> so a blk_flush_plug call just before a yield() is not needed.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: xfs/fs/ufs/truncate.c
> ===================================================================
> --- xfs.orig/fs/ufs/truncate.c	2011-03-30 11:35:58.095660392 +0200
> +++ xfs/fs/ufs/truncate.c	2011-03-30 11:36:03.487659988 +0200
> @@ -479,7 +479,6 @@ int ufs_truncate(struct inode *inode, lo
>  			break;
>  		if (IS_SYNC(inode) && (inode->i_state & I_DIRTY))
>  			ufs_sync_inode (inode);
> -		blk_flush_plug(current);
>  		yield();
>  	}

Added for .39 merge, thanks.

-- 
Jens Axboe