From mboxrd@z Thu Jan 1 00:00:00 1970 From: Venkateswararao Jujjuri Subject: Re: [PATCH] net/9p: nwname should be an unsigned int Date: Wed, 30 Mar 2011 17:51:02 -0700 Message-ID: <4D93CFF6.6070001@linux.vnet.ibm.com> References: <1301516283-21753-1-git-send-email-harsh@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, ericvh@gmail.com To: Harsh Prateek Bora Return-path: Received: from e8.ny.us.ibm.com ([32.97.182.138]:48004 "EHLO e8.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756556Ab1CaAvG (ORCPT ); Wed, 30 Mar 2011 20:51:06 -0400 Received: from d01dlp02.pok.ibm.com (d01dlp02.pok.ibm.com [9.56.224.85]) by e8.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p2V0QFwp001170 for ; Wed, 30 Mar 2011 20:26:15 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 1DEAD6E8039 for ; Wed, 30 Mar 2011 20:51:05 -0400 (EDT) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p2V0p4vT447858 for ; Wed, 30 Mar 2011 20:51:04 -0400 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p2V0p3YV007341 for ; Wed, 30 Mar 2011 18:51:04 -0600 In-Reply-To: <1301516283-21753-1-git-send-email-harsh@linux.vnet.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 03/30/2011 01:18 PM, Harsh Prateek Bora wrote: > Signed-off-by: Harsh Prateek Bora Reviewed-by: Venkateswararao Jujjuri > --- > include/net/9p/client.h | 2 +- > net/9p/client.c | 6 +++--- > net/9p/protocol.c | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/include/net/9p/client.h b/include/net/9p/client.h > index 0a30977..31e5343 100644 > --- a/include/net/9p/client.h > +++ b/include/net/9p/client.h > @@ -218,7 +218,7 @@ void p9_client_disconnect(struct p9_client *clnt); > void p9_client_begin_disconnect(struct p9_client *clnt); > struct p9_fid *p9_client_attach(struct p9_client *clnt, struct p9_fid *afid, > char *uname, u32 n_uname, char *aname); > -struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames, > +struct p9_fid *p9_client_walk(struct p9_fid *oldfid, uint16_t nwname, char **wnames, > int clone); > int p9_client_open(struct p9_fid *fid, int mode); > int p9_client_fcreate(struct p9_fid *fid, char *name, u32 perm, int mode, > diff --git a/net/9p/client.c b/net/9p/client.c > index 2ccbf04..1af4afb 100644 > --- a/net/9p/client.c > +++ b/net/9p/client.c > @@ -929,7 +929,7 @@ error: > } > EXPORT_SYMBOL(p9_client_attach); > > -struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames, > +struct p9_fid *p9_client_walk(struct p9_fid *oldfid, uint16_t nwname, char **wnames, > int clone) > { > int err; > @@ -937,7 +937,7 @@ struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames, > struct p9_fid *fid; > struct p9_qid *wqids; > struct p9_req_t *req; > - int16_t nwqids, count; > + uint16_t nwqids, count; > > err = 0; > wqids = NULL; > @@ -955,7 +955,7 @@ struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames, > fid = oldfid; > > > - P9_DPRINTK(P9_DEBUG_9P, ">>> TWALK fids %d,%d nwname %d wname[0] %s\n", > + P9_DPRINTK(P9_DEBUG_9P, ">>> TWALK fids %d,%d nwname %ud wname[0] %s\n", > oldfid->fid, fid->fid, nwname, wnames ? wnames[0] : NULL); > > req = p9_client_rpc(clnt, P9_TWALK, "ddT", oldfid->fid, fid->fid, > diff --git a/net/9p/protocol.c b/net/9p/protocol.c > index 8a4084f..0573b9b 100644 > --- a/net/9p/protocol.c > +++ b/net/9p/protocol.c > @@ -265,7 +265,7 @@ p9pdu_vreadf(struct p9_fcall *pdu, int proto_version, const char *fmt, > } > break; > case 'T':{ > - int16_t *nwname = va_arg(ap, int16_t *); > + uint16_t *nwname = va_arg(ap, uint16_t *); > char ***wnames = va_arg(ap, char ***); > > errcode = p9pdu_readf(pdu, proto_version, > @@ -495,7 +495,7 @@ p9pdu_vwritef(struct p9_fcall *pdu, int proto_version, const char *fmt, > } > break; > case 'T':{ > - int16_t nwname = va_arg(ap, int); > + uint16_t nwname = va_arg(ap, int); > const char **wnames = va_arg(ap, const char **); > > errcode = p9pdu_writef(pdu, proto_version, "w",