From mboxrd@z Thu Jan 1 00:00:00 1970 From: Venkateswararao Jujjuri Subject: Re: [V9fs-developer] [PATCH] net/9p: Handle get_user_pages_fast return properly Date: Tue, 19 Apr 2011 16:41:22 -0700 Message-ID: <4DAE1DA2.2070105@linux.vnet.ibm.com> References: <1302856173-10566-1-git-send-email-mohan@in.ibm.com> <4DA85BDC.5030407@linux.vnet.ibm.com> <201104192054.49797.mohan@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: "M. Mohan Kumar" Return-path: In-Reply-To: <201104192054.49797.mohan@in.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 04/19/2011 08:24 AM, M. Mohan Kumar wrote: > On Friday 15 April 2011 8:23:16 pm Venkateswararao Jujjuri wrote: >>> - if (err != -ERESTARTSYS) >>> + if (err != -ERESTARTSYS&& err != -EFAULT) >> Please analyze other errors that could be returned by >> c->trans_mod->request() >> if they need any handling here. > Thanks JV, but we don't need to handle other errors as of now. *request could also return -EIO and -ENOMEM. As you said, may be we should leave the default behavior on these errors(suspend the channel). Thanks, JV > I will post a V2 patch with retaining printing error message. > ---- > M. Mohan Kumar