From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Kleikamp Subject: Re: [PATCH 1/2 v2] fs: add SEEK_HOLE and SEEK_DATA flags Date: Wed, 04 May 2011 16:54:14 -0500 Message-ID: <4DC1CB06.9060101@oracle.com> References: <1304531920-2890-1-git-send-email-josef@redhat.com> <15392.1304535887@localhost> <4DC1A49C.4010101@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org To: Josef Bacik Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:38800 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753169Ab1EDVyZ (ORCPT ); Wed, 4 May 2011 17:54:25 -0400 In-Reply-To: <4DC1A49C.4010101@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 05/04/2011 02:10 PM, Josef Bacik wrote: > On 05/04/2011 03:04 PM, Valdis.Kletnieks@vt.edu wrote: >> On Wed, 04 May 2011 13:58:39 EDT, Josef Bacik said: >> >>> -SEEK_HOLE: this moves the file pos to the nearest hole in the file >>> from the >>> given position. >> >> Nearest, or next? Solaris defines it as "next", for a good reason - >> otherwise >> you can get stuck in a case where the "nearest" hole is back towards the >> start of the file - and "seek data" will bounce back to the next byte at >> the other end of the hole. >> > > Yeah sorry the log says "nearest" but the code says "next", if you look > at it thats how it works. Thanks, The comments in fs.h say "closest". You may want to change them to "next" as well. Thanks, Shaggy