From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josef Bacik Subject: Re: [PATCH 1/2] fs: add a DCACHE_NEED_LOOKUP flag for d_flags Date: Fri, 20 May 2011 20:30:19 -0400 Message-ID: <4DD7079B.6070302@redhat.com> References: <1305827929-18491-1-git-send-email-josef@redhat.com> <7B320C9C-0748-419B-9E40-7A15397E0064@dilger.ca> <20110520213112.GS12317@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Andreas Dilger , "linux-btrfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "viro@ZenIV.linux.org.uk" , "hch@lst.de" , "aarcange@redhat.com" To: Andi Kleen Return-path: Received: from mx1.redhat.com ([209.132.183.28]:20968 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810Ab1EUAaf (ORCPT ); Fri, 20 May 2011 20:30:35 -0400 In-Reply-To: <20110520213112.GS12317@one.firstfloor.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 05/20/2011 05:31 PM, Andi Kleen wrote: >> Putting them at the end of the cache LRU instead of the head would allow them to be dropped quickly under memory pressure. > > This still would fill up your memory for find /, potentially pushing > out other stuff. > > -Andi So these things are just hashed on dput, so they don't have any references to them and they are automatically put on the LRU list, so if we get under memory pressure they will be easily discarded, especially if nobody is actually stating them. Thanks, Josef