From mboxrd@z Thu Jan  1 00:00:00 1970
From: sdrb <sdrb@onet.eu>
Subject: Re: Semaphore should be released in get_super
Date: Tue, 24 May 2011 14:04:03 +0200
Message-ID: <4DDB9EB3.2070400@onet.eu>
References: <4DDB8317.7040300@onet.eu> <20110524112007.GD26392@parisc-linux.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
To: linux-fsdevel@vger.kernel.org
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtpo05.poczta.onet.pl ([213.180.142.136]:44851 "EHLO
	smtpo05.poczta.onet.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754437Ab1EXME0 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 24 May 2011 08:04:26 -0400
Received: from localhost.localdomain (unknown [83.238.22.2])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	(Authenticated sender: sdrb@onet.eu)
	by smtp.poczta.onet.pl (Onet) with ESMTPSA id D0E48200B2F08
	for <linux-fsdevel@vger.kernel.org>; Tue, 24 May 2011 14:04:24 +0200 (CEST)
In-Reply-To: <20110524112007.GD26392@parisc-linux.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 05/24/2011 01:20 PM, Matthew Wilcox wrote:
> On Tue, May 24, 2011 at 12:06:15PM +0200, sdrb wrote:
>> Hello,
>>
>> Probably I found a bug in get_super() proc. I think there should be
>> semaphore released before return sb.
>
> That's the point of get_super().  It's supposed to return with the
> semaphore held.  Users call drop_super() later which releases the
> semaphore.

Sorry, my mistake - I noticed drop_user() just a few minutes after I 
sent a post :)