From: Eric Sandeen <sandeen@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: XFS <xfs@oss.sgi.com>, Sergey Ivanov <sergey57@gmail.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] xfstests: add support for ext4dev FSTYP
Date: Wed, 01 Jun 2011 00:34:36 -0500 [thread overview]
Message-ID: <4DE5CF6C.4080707@redhat.com> (raw)
In-Reply-To: <4DE5CC8E.1090208@redhat.com>
On 6/1/11 12:22 AM, Eric Sandeen wrote:
> On 5/31/11 11:56 PM, Amir Goldstein wrote:
>> On Wed, Jun 1, 2011 at 7:37 AM, Eric Sandeen <sandeen@redhat.com> wrote:
>>> On 5/31/11 10:13 PM, Amir Goldstein wrote:
>>>> From: Amir Goldstein <amir73il@users.sf.net>
>>>>
>>>> blkid knows to identify the ext4dev FSTYP of a partition that was
>>>> formatted with mkfs.ext4dev.
>>>> quota tools and various util-linux utils are also aware of ext4dev,
>>>> so ext4dev shares the same capabilities as ext4.
>>>>
>>>> While testing on Fedora 15, we encoutered a buggy fsck utility, which
>>>> invokes fsck.ext4, even though it was called with -t ext4dev argument.
>>>> In our setup fsck.ext4dev knows about new fs features that fsck.ext4
>>>> doesn't know, so the generic_fs_check fails.
>>>> Since we have no real use of the extra capabilities provided by fsck util,
>>>> we decided to invoke fsck.$FSTYP directly to avoid this issue.
>>>
>>> Adding ext4dev to every case seems harmless enough. TBH I thought I had
>>> it there already but I guess not.
>>>
>>> I'm less certain of the change from fsck -t $FSTYP to fsck.$FSTYP
>>>
>>> What issue are you avoiding? wouldn't fsck -t ext4dev invoke fsck.ext4dev anyway?
>>>
>>> It seems like it should be harmless, but I don't understand how it helps you.
>>>
>>
>> As I wrote in the patch description, the fsck utility in Fedora 15 invokes
>> fsck.ext4 for some reason when calling fsck -t ext4dev.
>
> Oh, right.
>
>> this fails because fsck.ext4 doesn't know the snapshot feature.
>> I didn't debug fsck utility for that. it seemed pointless.
>
> Did you file a bug with Fedora? I'd rather fix the root cause than work around it...
> Feel free to cc: me on the bug.
RHEL6 does the same; mkfs.ext4dev then fsck -t ext4dev invokes fsck.ext4; but this
is because blkid identifies it as ext4, not ext4dev, despite the test_fs flag being set.
ISTR this is due to some tortured logic about when ext4dev isn't ext4dev, but
I don't remember the details... I don't know if this is the same situation
you're seeing; just to double check - does blkid correctly identify it as ext4dev
on F15?
-Eric
> -Eric
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-06-01 5:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 3:13 [PATCH] xfstests: add support for ext4dev FSTYP Amir Goldstein
2011-06-01 4:37 ` Eric Sandeen
2011-06-01 4:56 ` Amir Goldstein
2011-06-01 5:22 ` Eric Sandeen
2011-06-01 5:34 ` Eric Sandeen [this message]
2011-06-01 6:37 ` Amir Goldstein
2011-06-01 11:48 ` sergey ivanov
2011-06-01 12:37 ` Amir Goldstein
2011-06-01 15:27 ` Eric Sandeen
2011-06-02 1:47 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE5CF6C.4080707@redhat.com \
--to=sandeen@redhat.com \
--cc=amir73il@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sergey57@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).