linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	viro@ZenIV.linux.org.uk
Subject: Re: [PATCH -v3] vfs: make unlink() and rmdir() return ENOENT in preference to EROFS
Date: Tue, 07 Jun 2011 18:16:20 +0400	[thread overview]
Message-ID: <4DEE32B4.509@msgid.tls.msk.ru> (raw)
In-Reply-To: <1307402380-14166-1-git-send-email-tytso@mit.edu>

07.06.2011 03:19, Theodore Ts'o wrote:
> If user space attempts to remove a non-existent file or directory, and
> the file system is mounted read-only, return ENOENT instead of EROFS.
> Either error code is arguably valid/correct, but ENOENT is a more
> specific error message.
> 
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

Thank you very much for this patch.  I had no chance to test it before,
now I've tested it and it works as expected - now both rm(1) and rmdir(1)
behave correctly, and git rm works too.

It's interesting to note that it's been this way for several years
(when the change occured?), and there has been no complains so far... ;)

Thanks!

/mjt

  parent reply	other threads:[~2011-06-07 14:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06 20:36 [PATCH] vfs: make unlink() return ENOENT in preference to EROFS Theodore Ts'o
2011-06-06 20:45 ` Arnaud Lacombe
2011-06-06 20:58   ` [PATCH -v2] " Theodore Ts'o
2011-06-06 22:30     ` Al Viro
2011-06-06 22:48       ` Michael Tokarev
2011-06-06 23:19         ` [PATCH -v3] vfs: make unlink() and rmdir() " Theodore Ts'o
2011-06-07  0:05           ` Al Viro
2011-06-07 14:16           ` Michael Tokarev [this message]
2011-07-02  0:50           ` [-v3] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DEE32B4.509@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).