From mboxrd@z Thu Jan 1 00:00:00 1970 From: KOSAKI Motohiro Subject: Re: [PATCH 01/12] vmscan: add shrink_slab tracepoints Date: Mon, 20 Jun 2011 09:44:33 +0900 Message-ID: <4DFE97F1.2030206@jp.fujitsu.com> References: <1306998067-27659-1-git-send-email-david@fromorbit.com> <1306998067-27659-2-git-send-email-david@fromorbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xfs@oss.sgi.com To: david@fromorbit.com Return-path: In-Reply-To: <1306998067-27659-2-git-send-email-david@fromorbit.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org (2011/06/02 16:00), Dave Chinner wrote: > From: Dave Chinner >=20 > =D0=86t is impossible to understand what the shrinkers are actually doi= ng > without instrumenting the code, so add a some tracepoints to allow > insight to be gained. >=20 > Signed-off-by: Dave Chinner > --- > include/trace/events/vmscan.h | 67 +++++++++++++++++++++++++++++++++= ++++++++ > mm/vmscan.c | 6 +++- > 2 files changed, 72 insertions(+), 1 deletions(-) This look good to me. I have two minor request. 1) please change patch or= der, move this patch after shrinker changes. iow, now both this and [2/12] hav= e tracepoint change. I don't like it. 2) please avoid cryptic abbreviated v= ariable names. Instead, please just use the same variable name with vmscan.c sour= ce code. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter= .ca/ Don't email: email@kvack.org